always upload test logs

lenskit · Jul 24, 2024 · fe1b9a8 · fe1b9a8
1 parent f7f5866
commit fe1b9a8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -77,6 +77,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-conda-${{matrix.platform}}-py${{matrix.python}}
           path: |
@@ -137,6 +138,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-vanilla-${{matrix.platform}}-py${{matrix.python}}
           path: |
@@ -189,6 +191,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-nojit
           path: |
@@ -238,6 +241,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-mindep
           path: |
@@ -295,6 +299,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-funksvd-py${{matrix.python}}
           path: |
@@ -344,6 +349,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-mindep-funksvd
           path: |
@@ -401,6 +407,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-implicit-py${{matrix.python}}
           path: |
@@ -450,6 +457,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-mindep-implicit
           path: |
@@ -506,6 +514,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-hpf-py${{matrix.python}}
           path: |
@@ -562,6 +571,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-eval-tests
           path: |
@@ -618,6 +628,7 @@ jobs:
           coverage report
       - name: 📤 Upload test results
         uses: actions/upload-artifact@v4
+        if: always()
         with:
           name: test-examples
           path: |

diff --git a/lkdev/ghactions.py b/lkdev/ghactions.py
@@ -48,6 +48,7 @@ def command(cls, args: list[str]):
         "id": NotRequired[str],
         "name": NotRequired[str],
         "uses": NotRequired[str],
+        "if": NotRequired[str],
         "run": NotRequired[str | script],
         "shell": NotRequired["str"],
         "with": NotRequired[dict[str, str | int | bool | script]],

diff --git a/lkdev/workflows/test.py b/lkdev/workflows/test.py
@@ -257,6 +257,7 @@ def steps_coverage(options: JobOptions) -> list[GHStep]:
         {
             "name": "📤 Upload test results",
             "uses": "actions/upload-artifact@v4",
+            "if": "always()",
             "with": {
                 "name": options.test_artifact_name,
                 "path": script("""