Use common/logger everywhere, remove main/logger export #4317
Conversation
Nokel81
requested review from
jweak and
aleksfront
and removed request for
a team
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
single-logger
branch
from
cd7b429 to
58638cb
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Nokel81
force-pushed
the
single-logger
branch
from
58638cb to
e7ced08
Compare
|
@jakolehm I have undone the changes to |
| import { consoleFormat } from "winston-console-format"; | ||
| import { isDebugging, isTestEnv } from "./vars"; | ||
| import BrowserConsole from "winston-transport-browserconsole"; |
There was a problem hiding this comment.
Could you clarify why we are removing winston completely from renderer?
There was a problem hiding this comment.
Sure, there are several reasons:
- Winston does not interact nicely with DevTools and the verbosity selector
- "winston-transport-browserconsole" has a bug where any "meta-data" after the second entry is ignored (which I believe is intentional)
src/common/logger.ts
Outdated
|
|
||
| if (ipcMain) { | ||
| transports.push( | ||
| if (isTestEnv) { |
There was a problem hiding this comment.
This feels a bit odd because it relies on a global state... would it be better to have it as a function arg?
There was a problem hiding this comment.
As a function argument to what? I could add a testing function that could be called to mock out the logger, is that what you mean?
Nokel81
force-pushed
the
single-logger
branch
from
0199042 to
632bf27
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
single-logger
branch
from
632bf27 to
2134f8f
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Nokel81
force-pushed
the
single-logger
branch
from
f0cfb7f to
875bc95
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Nokel81
force-pushed
the
single-logger
branch
from
378a1ec to
d69a3ce
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- in Renderer make it 'console' which a stub for silly level - in Main make it a winston logger with file output as well - in testing make it a jest mock stub - in all other cases make it a winston logger without file output - Turn on no-console - Fix logger during integration testing Signed-off-by: Sebastian Malton <[email protected]>
Nokel81
force-pushed
the
single-logger
branch
from
bb339e8 to
9900006
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Closing this as we probably will want two logger injectables in the future. |
in Renderer make it 'console' which a stub for silly level
in Main make it a winston logger with file output as well
in testing make it a jest mock stub
in all other cases make it a winston logger without file output
Signed-off-by: Sebastian Malton [email protected]