Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @material-ui/core console errors #3658

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

aleksfront
Copy link
Contributor

@material-ui/lab dependency should be bumped after #3554 to avoid some warnings.

image

Signed-off-by: Alex Andreev [email protected]

Signed-off-by: Alex Andreev <[email protected]>
@aleksfront aleksfront added bug Something isn't working chore labels Aug 23, 2021
@aleksfront aleksfront added this to the 5.2.0 milestone Aug 23, 2021
@aleksfront aleksfront requested a review from a team as a code owner August 23, 2021 11:52
@aleksfront aleksfront requested review from Nachasic and removed request for a team August 23, 2021 11:52
@aleksfront
Copy link
Contributor Author

Can't make Require Release Category Labels / label have although I have all labels set.

@aleksfront aleksfront added chore and removed bug Something isn't working area/ui chore labels Aug 23, 2021
@aleksfront
Copy link
Contributor Author

@Nokel81 I found that setting both chore and bug breaks the Require Release Category Labels check. How do you think is this an issue or not?

@Nokel81
Copy link
Collaborator

Nokel81 commented Aug 23, 2021

@aleksfront Those labels are used for the release drafter which is why the need to be XOR. I would label this a bug

@aleksfront aleksfront added bug Something isn't working and removed chore labels Aug 23, 2021
@aleksfront aleksfront merged commit 4fd0796 into master Aug 23, 2021
@aleksfront aleksfront deleted the fix-material-core-warnings branch August 23, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants