Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass KubeObjectStore.api via constructor #3596

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Allow to pass KubeObjectStore.api via constructor #3596

merged 3 commits into from
Aug 12, 2021

Conversation

jakolehm
Copy link
Contributor

Allows to create a store per api/cluster:

const api = Main.K8sApi.forCluster(cluster, MyCustomResource);
const store = new MyCustomResourceStore(api);

@jakolehm jakolehm added enhancement New feature or request area/extension Something to related to the extension api semver/minor labels Aug 12, 2021
@jakolehm jakolehm added this to the 5.2.0 milestone Aug 12, 2021
@jakolehm jakolehm requested a review from nevalla August 12, 2021 07:03
@jakolehm jakolehm requested a review from a team as a code owner August 12, 2021 07:03
@jakolehm jakolehm requested review from Nokel81 and removed request for a team August 12, 2021 07:03
@jakolehm
cleanup
0925a5e 
Signed-off-by: Jari Kolehmainen <[email protected]>
nevalla
nevalla previously approved these changes Aug 12, 2021
View reviewed changes
@jakolehm jakolehm merged commit be6df7d into master Aug 12, 2021
@jakolehm jakolehm deleted the fix/allow-to-pass-store-api-via-constructor branch August 12, 2021 08:13
@Nokel81 Nokel81 mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevalla nevalla nevalla approved these changes

@Nokel81 Nokel81 Awaiting requested review from Nokel81

Assignees
No one assigned
Labels
area/extension Something to related to the extension api enhancement New feature or request
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jakolehm @nevalla