-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move lookupApi into apiManager #3540
Conversation
2515010
to
3a3ff91
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cc559f0
to
28bd6d0
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
3a3ff91
to
ec924bc
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- Don't export kube-api-parse from kube-api (cir-deps) Signed-off-by: Sebastian Malton <[email protected]>
28bd6d0
to
1f38d62
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Signed-off-by: Sebastian Malton <[email protected]>
Not sure if this is related to something in this chain of PRs: definitionShowsDetails.movClicking on a definition sometimes brings up the details page, when it should bring up the list of CRD instances? |
@jim-docker Do you mean that it is strange that the drawer opens when you click the row near the name of the CRD but opens the list of resources if you click the name? I think that has always been the situation. |
Ah, I see, I was clicking just below the word "Prometheus", such that it wasn't highlighted (wasn't white instead of blue), hence the details came up |
Yes I agree, that it is a bit of a bad design and should probably open the list of resources when clicking that entire cell (and not just the text), but that is for a different PR. |
Signed-off-by: Sebastian Malton [email protected]
part of splitting apart ban-cir-deps