Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase timeout for getPortFrom() #3511

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

jim-docker
Copy link
Contributor

5s may not be enough time to get a port through kubectl proxy, particularly on Windows, where a number of "failed to retrieve port from stream" Sentry events are occurring. Since it has been hard to reproduce the issue this is a first attempt at a solution.

@jim-docker jim-docker requested a review from a team as a code owner July 23, 2021 20:43
@jim-docker jim-docker requested review from nevalla and jakolehm and removed request for a team July 23, 2021 20:43
@jim-docker jim-docker added the bug Something isn't working label Jul 23, 2021
@Nokel81
Copy link
Collaborator

Nokel81 commented Jul 23, 2021

If you run kubectl proxy manually. How long does it take to start?

@jim-docker
Copy link
Contributor Author

If you run kubectl proxy manually. How long does it take to start?

About a second or so, but that was when I couldn't reproduce the issue. The one time I saw it was right after a cold start of my windows machine, but haven't timed kubectl proxy then. Will try. Also, looking at the recent Sentry events, the breadcrumbs often (most times?) show [LENS-VIEW]: remove dashboard log message just before the port failure exception, which is odd...

@jim-docker jim-docker merged commit fd5881f into master Jul 23, 2021
@jim-docker jim-docker deleted the bug/failed-to-retrieve-port-from-stream branch July 23, 2021 21:16
@Nokel81 Nokel81 added this to the 5.2.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants