Improve <NamespaceSelectFilter>'s UX #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokel81
requested review from
nevalla,
Nachasic,
aleksfront and
jim-docker
and removed request for
a team
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
- Display previously selected namespaces at the top of the option list when first opened - Don't resort after every selection - Automatically close the option list if no longer in multi-select mode and have toggled at least one namespace Signed-off-by: Sebastian Malton <[email protected]>
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Nachasic
approved these changes
Jul 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display previously selected namespaces at the top of the option list
when first opened
Don't resort after every selection
Automatically close the option list if no longer in multi-select mode
and have toggled at least one namespace
Signed-off-by: Sebastian Malton [email protected]
fixes #1231