Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubectl to v1.21.2 #3267

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Update kubectl to v1.21.2 #3267

merged 2 commits into from
Aug 2, 2021

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Jul 5, 2021

Fixes #541

Signed-off-by: Jari Kolehmainen <[email protected]>
@jakolehm jakolehm added the bug Something isn't working label Jul 5, 2021
@jakolehm jakolehm requested a review from a team as a code owner July 5, 2021 11:32
@jakolehm jakolehm requested review from Nokel81 and Nachasic and removed request for a team July 5, 2021 11:32
@jakolehm
Copy link
Contributor Author

jakolehm commented Jul 5, 2021

After testing this a bit more it seems that we still have issues.

jim-docker
jim-docker previously approved these changes Jul 5, 2021
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason why we weren't already bundling newer than 1.18?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

nevalla
nevalla previously approved these changes Aug 2, 2021
@nevalla
Copy link
Contributor

nevalla commented Aug 2, 2021

Do I remember wrong, but do we have any issues open that this PR will fix, something related to proxy settings?

@jakolehm
Copy link
Contributor Author

jakolehm commented Aug 2, 2021

Do I remember wrong, but do we have any issues open that this PR will fix, something related to proxy settings?

As mentioned in the PR description this should fix #541 🙂

@jakolehm jakolehm dismissed stale reviews from nevalla and jim-docker via 3a39c66 August 2, 2021 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Conflicts have been resolved. A maintainer will review the pull request shortly.

@jakolehm
Copy link
Contributor Author

jakolehm commented Aug 2, 2021

@nevalla ptal again.

@jakolehm jakolehm added this to the 5.2.0 milestone Aug 2, 2021
@nevalla
Copy link
Contributor

nevalla commented Aug 2, 2021

Do I remember wrong, but do we have any issues open that this PR will fix, something related to proxy settings?

As mentioned in the PR description this should fix #541 🙂

🙈

@jakolehm jakolehm merged commit dc5a885 into master Aug 2, 2021
@jakolehm jakolehm deleted the bundle-kubectl-1.20.2 branch August 2, 2021 16:11
@Nokel81 Nokel81 mentioned this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port-Forwarding does not keep connection alive
3 participants