Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Ace editor with Monaco #2949

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Replace Ace editor with Monaco #2949

merged 2 commits into from
Aug 12, 2021

Conversation

pashevskii
Copy link
Contributor

@pashevskii pashevskii commented Jun 3, 2021 •
edited
Loading

Peek 2021-06-22 17-47
Replaces Ace Editor with Monaco Editor

Implements #458

@pashevskii pashevskii force-pushed the monaco-editor branch 3 times, most recently from 7b6677c to 920960e Compare June 4, 2021 09:19
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@pashevskii pashevskii force-pushed the monaco-editor branch 4 times, most recently from 6814152 to 79c0c81 Compare June 9, 2021 14:03
@msa0311 msa0311 added this to the 5.0.1 milestone Jun 14, 2021
@pashevskii pashevskii force-pushed the monaco-editor branch 3 times, most recently from 03710fd to 63441e8 Compare June 23, 2021 11:10
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@pashevskii pashevskii marked this pull request as ready for review June 23, 2021 11:11
@pashevskii pashevskii requested a review from a team as a code owner June 23, 2021 11:11
@pashevskii pashevskii requested review from nevalla and Nokel81 and removed request for a team June 23, 2021 11:11
nevalla
nevalla requested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Added this point some comments to remove empty lines to make diff smaller.

@pashevskii pashevskii marked this pull request as draft June 23, 2021 12:58
@pashevskii
Copy link
Contributor Author

Converted to draft for removing Ace dependency at all from the lens (not just for tabs)

Nokel81
Nokel81 reviewed Jun 23, 2021
View reviewed changes
@pashevskii pashevskii force-pushed the monaco-editor branch 3 times, most recently from 0b03695 to a455447 Compare June 24, 2021 06:06
@pashevskii pashevskii force-pushed the monaco-editor branch 2 times, most recently from 8b26d95 to d8ad951 Compare August 11, 2021 10:00
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@pashevskii pashevskii force-pushed the monaco-editor branch 2 times, most recently from 8b7ab2e to 43ba4b0 Compare August 11, 2021 11:51
@pashevskii
Copy link
Contributor Author

image
thanks @aleksfront, unit tests are fixed

@pashevskii pashevskii force-pushed the monaco-editor branch 3 times, most recently from fd53ddd to 074c73e Compare August 11, 2021 14:06
aleksfront
aleksfront previously approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pashevskii
Replace Ace Editor with monaco
f0f652c 
Signed-off-by: Pavel Ashevskii <[email protected]>
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

nevalla
nevalla approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm dismissed Nokel81’s stale review August 12, 2021 10:00

PR already has 2 approvals

@jakolehm jakolehm merged commit e4c3932 into lensapp:master Aug 12, 2021
@Nokel81 Nokel81 mentioned this pull request Aug 16, 2021
Merged
@aleksfront aleksfront mentioned this pull request Aug 17, 2021
Closed
@Nokel81 Nokel81 mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nokel81 Nokel81 Nokel81 left review comments

@nevalla nevalla nevalla approved these changes

@aleksfront aleksfront aleksfront approved these changes

Assignees
No one assigned
Labels
area/ui enhancement New feature or request p2
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pashevskii @Nokel81 @aleksfront @nevalla @jakolehm @msa0311