Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Increase npm version to 7.9" #2583

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Revert "Increase npm version to 7.9" #2583

merged 1 commit into from
Apr 21, 2021

Conversation

jakolehm
Copy link
Contributor

Reverts #2466 because of npm/cli#2380

@jakolehm jakolehm added bug Something isn't working blocker labels Apr 21, 2021
@jakolehm jakolehm added this to the 5.0.0 milestone Apr 21, 2021
@jakolehm jakolehm requested a review from Nokel81 April 21, 2021 12:38
@jakolehm jakolehm requested a review from a team as a code owner April 21, 2021 12:38
@jakolehm jakolehm requested review from aleksfront and removed request for a team April 21, 2021 12:38
Nokel81
Nokel81 approved these changes Apr 21, 2021
View reviewed changes
Copy link
Collaborator

@Nokel81 Nokel81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add our case to that issue.

@jakolehm jakolehm merged commit b2a570c into master Apr 21, 2021
@jakolehm jakolehm deleted the revert-2466-issue-2465 branch April 21, 2021 13:29
@jakolehm jakolehm mentioned this pull request Apr 22, 2021
Merged
@Nokel81
Copy link
Collaborator

Nokel81 commented Oct 15, 2021

@jakolehm Do you remember where we use npm link at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nokel81 Nokel81 Nokel81 approved these changes

@jim-docker jim-docker jim-docker approved these changes

@aleksfront aleksfront Awaiting requested review from aleksfront

Assignees
No one assigned
Labels
blocker bug Something isn't working
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jakolehm @Nokel81 @jim-docker