Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use public instead of external #29

Closed
wants to merge 1 commit into from
Closed

use public instead of external #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contracts/Loan.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ contract Loan {
string reason,
uint256 timestamp
)
external
public
onlyWorker
{
emit TransferExpected(
Expand All @@ -85,7 +85,7 @@ contract Loan {
bytes32 txid,
uint256 timestamp
)
external
public
onlyWorker
{
emit TransferObserved(
Expand All @@ -103,7 +103,7 @@ contract Loan {
function updateMeta(
string updatedMeta
)
external
public
onlyWorker
{
emit MetaUpdated(updatedMeta, seq++);
Expand Down
10 changes: 5 additions & 5 deletions contracts/LoanFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ contract LoanFactory {
* to solve the issue
*/
function createLoan(string id, string loanMeta)
external
public
onlyWorker
{
loans.push(new Loan(id, loanMeta));
Expand All @@ -66,15 +66,15 @@ contract LoanFactory {
}

function changeOwner(address _pendingOwner)
external
public
onlyOwner
{
emit AccessChanged("pendingOwner", pendingOwner, _pendingOwner);
pendingOwner = _pendingOwner;
}

function acceptOwner()
external
public
{
require(msg.sender == pendingOwner);
emit AccessChanged("owner", owner, pendingOwner);
Expand All @@ -84,15 +84,15 @@ contract LoanFactory {
}

function changeWorker(address _worker)
external
public
onlyOwner
{
emit AccessChanged("worker", worker, _worker);
worker = _worker;
}

function changeLeadtime(bytes32 leadTimeType, uint256 leadTime, uint256 timestamp)
external
public
onlyWorker
{
emit LeadTimeChanged(
Expand Down