Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simplecov version to 0.14.1 #119

Closed
wants to merge 1 commit into from

Conversation

potomak
Copy link

@potomak potomak commented Mar 19, 2017

Note: simplecov 0.14.0 fixed an issue that was breaking the example at
spec/coveralls/simplecov_spec.rb:75.

Before the result of #get_source_files for fixtures/sample.rb was:

00 COUNTED - # Foo class
01 COUNTED - class Foo
02 COUNTED -   def initialize
03 COUNTED -     @foo = 'baz'
04 COUNTED -   end
05 COUNTED -
06 COUNTED -   # :nocov:
07 SKIPPED -   def bar
08 SKIPPED -     @foo
09 SKIPPED -   end
10 COUNTED -   # :nocov:
11 COUNTED - end

Using simplecov 0.14.1, that includes
simplecov-ruby/simplecov#551, the result is:

00 COUNTED - # Foo class
01 COUNTED - class Foo
02 COUNTED -   def initialize
03 COUNTED -     @foo = 'baz'
04 COUNTED -   end
05 COUNTED -
06 SKIPPED -   # :nocov:
07 SKIPPED -   def bar
08 SKIPPED -     @foo
09 SKIPPED -   end
10 SKIPPED -   # :nocov:
11 COUNTED - end

Note: simplecov 0.14.0 fixed an issue that was breaking the example at
`spec/coveralls/simplecov_spec.rb:75`.

Before the result of `#get_source_files` for `fixtures/sample.rb` was:

```
00 COUNTED - # Foo class
01 COUNTED - class Foo
02 COUNTED -   def initialize
03 COUNTED -     @foo = 'baz'
04 COUNTED -   end
05 COUNTED -
06 COUNTED -   # :nocov:
07 SKIPPED -   def bar
08 SKIPPED -     @foo
09 SKIPPED -   end
10 COUNTED -   # :nocov:
11 COUNTED - end
```

Using simplecov 0.14.1, that includes
simplecov-ruby/simplecov#551, the result is:

```
00 COUNTED - # Foo class
01 COUNTED - class Foo
02 COUNTED -   def initialize
03 COUNTED -     @foo = 'baz'
04 COUNTED -   end
05 COUNTED -
06 SKIPPED -   # :nocov:
07 SKIPPED -   def bar
08 SKIPPED -     @foo
09 SKIPPED -   end
10 SKIPPED -   # :nocov:
11 COUNTED - end
```
@potomak
Copy link
Author

potomak commented Mar 19, 2017

It seems like there's already an open PR to address this.

@potomak potomak closed this Mar 19, 2017
@potomak potomak deleted the update-simplecov branch March 19, 2017 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant