Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remove-lodash-library] Remove usage of lodash library #289

Merged
merged 2 commits into from
Jan 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

## Next
### Maintainance
* Remove dev lodash library
* Update ava test runner to v3
* Update chance-access-token library to v2
* Update nyc instrumentation library to v15
* Update chance-access-token dev library to v2
* Update nyc instrumentation dev library to v15

## 3.1.0
### New features
Expand Down
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"contributors": [
"Jonathan Samines <[email protected]>"
],
"license": "Apache-2.0",
"homepage": "https://github.com/lelylan/simple-oauth2",
"main": "index.js",
"files": [
Expand Down Expand Up @@ -59,9 +60,7 @@
"eslint": "^6.8.0",
"eslint-config-airbnb-base": "^14.0.0",
"eslint-plugin-import": "^2.20.0",
"lodash": "^4.17.15",
"nock": "^11.7.2",
"nyc": "^15.0.0"
},
"license": "Apache-2.0"
}
}
9 changes: 9 additions & 0 deletions test/_property.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';

const has = (...args) => Object.prototype.hasOwnProperty.call(...args);
const hasIn = (object, propertyName) => propertyName in object;

module.exports = {
has,
hasIn,
};
2 changes: 1 addition & 1 deletion test/access_token.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
const test = require('ava');
const Chance = require('chance');
const accessTokenMixin = require('chance-access-token');
const { has, hasIn } = require('lodash');
const { isValid, isDate, differenceInSeconds } = require('date-fns');

const oauth2Module = require('./../index.js');
const { has, hasIn } = require('./_property');
const { createModuleConfig } = require('./_module-config');
const { createAuthorizationServer } = require('./_authorization-server-mock');

Expand Down