Follow redirects #189
Closed
Follow redirects #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instruct wreck to follow up to 20 redirects.
|
@AlasdairWilkins This is already possible because you are allowed to override most of the options from the underlying wreck library. Not sure if we should set a default number of redirections though. See: https://github.com/lelylan/simple-oauth2#options |
jonathansamines
added a commit
that referenced
this pull request
Sep 24, 2019
Follow up to 20 redirects (browsers standard). Resolves #189
|
Resolved by #255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruct wreck to follow up to 20 redirects.
I was trying to get a token from a server that redirected from the bare domain to www, which wasn't working because wreck wasn't instructed to follow redirects. Unless there's a security consideration, this seems like it makes the library more ergonomic. I picked 20 redirects because that seems to be standard for browsers.