Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladislas/feature/move to vanilla cmake #397

Closed
wants to merge 15 commits into from
Closed

ladislas/feature/move to vanilla cmake #397

wants to merge 15 commits into from

Conversation

ladislas
Copy link
Member

  • 🔥 (cmake): Remove USCRPL/mbed-cmake
  • 🚧 (cmake): Add mbed cmake dirs
  • 🚧 (cmake): Update main CMakeLists.txt
  • 👽 (cmake): Rewrite custom targets following porting guide
  • 🔥 (targets): Remove old dev targets
  • 🚚 (targets): Remove TARGET_ prefix for target directories
  • 🚨 (cmake): Add -Wno-volatile & -Wno-register flags
  • 🔥 (cmake): Remove CODE_ANALYSIS

@ladislas
🔥 (cmake): Remove USCRPL/mbed-cmake
b1d7f75
@ladislas
🚧 (cmake): Add mbed cmake dirs
9e38585
@ladislas
🚧 (cmake): Update main CMakeLists.txt
5533b58
@ladislas
👽 (cmake): Rewrite custom targets following porting guide
a1e99e5 
With mbed's cmake, targets:

- must be made CMake INTERFACE
- must be renamed in lower case, starting with 'mbed-' prefix

See https://os.mbed.com/docs/mbed-os/v6.15/porting/porting-custom-boards.html
@ladislas
🔥 (targets): Remove old dev targets
bc8c3f3 
Keep repo clean and remove unused code
@ladislas
🚚 (targets): Remove TARGET_ prefix for target directories
6a2f71d 
It was used by the old mbed-cli tools but it not needed anymore with
mbed-tools v2
@ladislas
🚨 (cmake): Add -Wno-volatile & -Wno-register flags
db4e098 
As of -std=cxx20, compound assignment with 'volatile'-qualified left
operand is deprecated.

Adding the -Wno-volatile hides the warnings for mbed-os C code used in
C++ files.

Same goes for register.
@ladislas
🔥 (cmake): Remove CODE_ANALYSIS
3a0bc38 
CODE_ANALYSIS was done using cppcheck. Now that we have SonarCloud, we
can remove local code analysis.
@codecov
Copy link

codecov bot commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #397 (11c6929) into develop (1e3cba0) will not change coverage.
The diff coverage is n/a.

❗ Current head 11c6929 differs from pull request most recent head f32b8fb. Consider uploading reports for the commit f32b8fb to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #397     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           65         7     -58     
  Lines         1195       188   -1007     
===========================================
- Hits          1195       188   -1007
Impacted Files Coverage Δ
include/cxxsupport/lstd_span 100.00% <0.00%> (ø)
drivers/CorePwm/include/CorePwm.h
drivers/CorePwm/source/CorePwm.cpp
...rs/CoreBufferedSerial/include/CoreBufferedSerial.h
include/interface/drivers/FirmwareUpdate.h
drivers/CoreBattery/include/CoreBattery.h
drivers/CoreI2C/include/CoreI2C.h
include/interface/platform/File.h
drivers/CoreVideo/include/interface/LTDC.hpp
libs/LKCalculatorKit/source/LKCalculatorKit.cpp
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3cba0...f32b8fb. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Dec 30, 2021

This pull request fixes 3 alerts when merging 3a0bc38 into 1e3cba0 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Dec 30, 2021

This pull request fixes 3 alerts when merging b3505ed into 1e3cba0 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Dec 31, 2021

This pull request fixes 3 alerts when merging 11c6929 into 1e3cba0 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@ladislas ladislas mentioned this pull request Dec 31, 2021
Closed
@ladislas ladislas mentioned this pull request Jan 11, 2022
Merged
@ladislas ladislas self-assigned this Jan 26, 2022
@ladislas ladislas marked this pull request as draft January 27, 2022 22:58
@ladislas ladislas added the 01 - type: task Something to do label Apr 4, 2022
@ladislas ladislas added this to the Future Release milestone Nov 16, 2022
@ladislas
Copy link
Member Author

replaced by #1296

@ladislas ladislas closed this Feb 20, 2023
@ladislas ladislas deleted the ladislas/feature/move-to-vanilla-cmake branch February 20, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ladislas ladislas

Labels
01 - type: task Something to do
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.
1 participant
@ladislas