-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Refreshing Devices During Deletes or Manually #806
Conversation
Do we really need this to be configurable? I'm ok with doing it by default, seems reasonable to me. |
I know some people have issues with timeouts when they get too many queries. Deleting multiple alarms in succession with automations would be likely to cause noise. Perhaps default to true but leave it there to allow the option to set it to false? |
Yeah, makes sense. Let's default to refresh and name it |
Makes sense will knock this out after work and get it all cleaned up. Just fixed my pre-commit to fix the linting. Running on a windows laptop atm :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
force_refresh
parameter todelete_timers
anddelete_alarms
refresh_devices
service to allow manual refreshesBoth options invoke
async_request_refresh
on the coordinator and therefore restart the refresh timer to prevent over-requesting devices. They provide a reasonable (and optional) method to immediately update devices when deleted, or to allow users to refresh timers/alarms.