Allow providing master_token during integration setup #723
Conversation
Integration now asks for master_token in the set-up process and is therefore able to access the Google API again
The initial version did not allow the usual set up process without a master_token Also mention this entire issue in the README
There was a problem hiding this comment.
Awesome, thanks for finding the time for fixing it :)
A small comment on how to make it possibly better. I would love to test it as well before we merge (will try to do it later today/tomorrow), since i have both username/password and master token working on my setup
Add reference to glocaltokens Co-authored-by: Ilja Leiko <[email protected]>
Make all input fields optional and check for configuration method based on the provided fields
…gle-home into fix/master-token
leikoilja
changed the title
Co-authored-by: Ilja Leiko <[email protected]>
simplify getting user inputs Co-authored-by: Ilja Leiko <[email protected]>
Co-authored-by: Ilja Leiko <[email protected]>
Add translations to all supported languages. However, these are mostly done using DeepL
Add missing translation for ca
Add a test which tries to get an access_token during the setup process
|
Updated the PR with a validity check for the master token as well as translations (using DeepL + Google Translator)✌️ |
leikoilja
added
feature
|
@Brephlas, since pre-commit hooks were failing on your last commit, i have pushed a minor refactoring to fix linting and typing issues. Please see the commit i just pushed if you agree with the changes :) I would also highly appreciate if you could pull these changes to your setup and verify that it still all works as expected before we merge :) |
|
Thanks for refactoring. Just did the tests on my setup and everything works as expected :) |
|
Closes #339 |
Small changed so that the Integration now asks for master_token in the set-up process and is therefore able to access the Google API again
Tested with my own environment/account and this was working fine.
Integration Set-up process:
Test timer on my office's google home device:
Might be a hacky solution but I tried to keep the usual set up process with an optional input field. Couldn't test this as I was getting the bad authentication error as well.