Bugfix: replace WiceGridController#send_file_rails2 with Rails' send_file #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
kreintjes
force-pushed
the
fix/csv-file-download
branch
from
5896103 to
335c239
Compare
Fixes Rails 5 deprecation warning concerning `render :text` and removes some obsolete code.
kreintjes
force-pushed
the
fix/csv-file-download
branch
from
335c239 to
eaeb12e
Compare
|
The first file is fixed in 50b7247. The second is not required for the version 6.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when trying to download a CSV export in combination with Turbolinks 5
(issue #326, credits to @nathanvda for the fix) and fixes Rails 5 deprecation warning concerning
render :text.