fix: implement concatenation for string and null value

fixes #956
leifg · Mar 1, 2023 · 00e19b7 · 00e19b7
1 parent 2201c31
commit 00e19b7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/functions.js b/src/functions.js
@@ -209,6 +209,8 @@ export const sf$add = (value1, value2) => {
       );
     case 'text text':
       return buildLiteralFromJs(value1.value + value2.value);
+    case 'text null':
+      return value1;
     default:
       ArgumentError.throwWrongType('add', 'number', value2.dataType);
   }

diff --git a/test/functions.spec.js b/test/functions.spec.js
@@ -896,6 +896,12 @@ describe('add', () => {
     });
   });
 
+  context('Text, Null', () => {
+    it('concats correctly', () => {
+      expect(dispatch('add', [buildLiteralFromJs('Black'), buildLiteralFromJs(null)])).to.deep.eq(buildLiteralFromJs('Black'));
+    });
+  });
+
   context('Date, Number', () => {
     it('adds number of days', () => {
       expect(dispatch('add', [buildDateLiteral(2020, 2, 11), buildLiteralFromJs(5)])).to.deep.eq(buildDateLiteral(2020, 2, 16));