Support optional calls in no-unused-expressions

Closes babel/babel-eslint#643
lehni · Sep 3, 2018 · d0f7952 · d0f7952
1 parent e565670
commit d0f7952
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/rules/no-unused-expressions.js b/rules/no-unused-expressions.js
@@ -42,8 +42,22 @@ function isInDoStatement(node) {
   return false;
 }
 
+/**
+ * @param {ASTNode} node - any node
+ * @returns {boolean} whether the given node is an optional call expression,
+ * see https://github.com/tc39/proposal-optional-chaining
+ */
+function isInOptionalCallExpression(node) {
+  return (
+    !!node &&
+    node.type === 'ExpressionStatement' &&
+    node.expression.type === 'OptionalCallExpression'
+  );
+}
+
 module.exports = ruleComposer.filterReports(
   rule,
-  (problem, metadata) => !isInDoStatement(problem.node)
+  (problem, metadata) =>
+    !isInDoStatement(problem.node) && !isInOptionalCallExpression(problem.node)
 );
 
diff --git a/tests/rules/no-unused-expressions.js b/tests/rules/no-unused-expressions.js
@@ -136,8 +136,9 @@ ruleTester.run("no-unused-expressions", rule, {
         },
 
         // Babel-specific test cases.
-      { code: "let a = do { foo; let b = 2; }", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }] },
+        { code: "let a = do { foo; let b = 2; }", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }] },
         { code: "let a = do { if (foo) { foo.bar } else { a; bar.foo } }", errors: [{ message: "Expected an assignment or function call and instead saw an expression.", type: "ExpressionStatement" }] },
+        { code: "function foo() { foo.bar?.(); }", errors: [] },
 
     ]
 });