Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Review on Indonesian Translation #219

Merged

Conversation

Takane42
Copy link

@Takane42 Takane42 commented Oct 3, 2021

Added Review on Indoensian Translation in Python

This pull request (PR) is made in reference to:
#157

@welcome
Copy link

welcome bot commented Oct 3, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@Takane42
Copy link
Author

Takane42 commented Oct 3, 2021

Uh... help? @madiedgar

Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @Takane42! 👍

@madiedgar
Copy link
Member

Uh... help? @madiedgar

Are you concerned about the tests failing? It's a bug that's fixed in the master branch, so no need to worry!

@welcome
Copy link

welcome bot commented Oct 3, 2021

🎉 Congrats on merging your first pull request! 🎉 ❤️ THANK YOU THANK YOU THANK YOU ❤️

We'd love to celebrate you and your contribution to the community. Let us say "Thank You" again, by sending you a special gift only given to special individuals like you who have chosen to give back.
We couldn't thank you enough for your contribution. We hope you continue sharing your gifts and knowledge with not just us, but with the world around you.😍

@madiedgar
Copy link
Member

Thank you again for your contribution! Really appreciate you 👏

@Takane42
Copy link
Author

Takane42 commented Oct 9, 2021

im sorry for the late reply but... sure no problem. Thanks for merge'ing my review @madiedgar

madiedgar pushed a commit that referenced this pull request Sep 28, 2022
- thank you @Takane42 for your contribution! 🎉
madiedgar pushed a commit that referenced this pull request Sep 18, 2023
- thank you @Takane42 for your contribution! 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants