Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Dialect: Spanish (Python) #145

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Review Dialect: Spanish (Python) #145

merged 2 commits into from
Oct 10, 2020

Conversation

gfant
Copy link

@gfant gfant commented Oct 9, 2020

Review Dialect: Spanish (Python)

This pull request (PR) is made in reference to: #37

Description

What does this PR do?

Added comments for the Spanish translation.

Checklist:

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@welcome
Copy link

welcome bot commented Oct 9, 2020

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

madiedgar
madiedgar approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@madiedgar madiedgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your additional comments in your contribution! Appreciate you!

@madiedgar madiedgar merged commit 2d2f8f2 into legesher:spanish-translation Oct 10, 2020
@welcome
Copy link

welcome bot commented Oct 10, 2020

🎉 Congrats on merging your first pull request! 🎉 ❤️ THANK YOU THANK YOU THANK YOU ❤️

We'd love to celebrate you and your contribution to the community. Let us say "Thank You" again, by sending you a special gift only given to special individuals like you who have chosen to give back.
We couldn't thank you enough for your contribution. We hope you continue sharing your gifts and knowledge with not just us, but with the world around you.😍

@madiedgar madiedgar mentioned this pull request Oct 10, 2020
Closed
16 tasks
@gfant
Copy link
Author

gfant commented Oct 10, 2020

You're welcome 😄! I will look for help in the other reviews 🙂.

@madiedgar madiedgar mentioned this pull request Dec 31, 2020
Open
madiedgar pushed a commit that referenced this pull request Oct 2, 2022
@gfant @madiedgar
Review Dialect: Spanish (Python) (#145)
bb6625a 
* Translation Spanish for #37

* Emojis changed for documentation match
* Thank you @iam-agf for your contribution 🎉
madiedgar pushed a commit that referenced this pull request Sep 18, 2023
@gfant @madiedgar
Review Dialect: Spanish (Python) (#145)
7aa3f6a 
* Translation Spanish for #37

* Emojis changed for documentation match
* Thank you @iam-agf for your contribution 🎉
@madiedgar madiedgar added this to the Spanish Language Translation milestone Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madiedgar madiedgar madiedgar approved these changes

Assignees

@gfant gfant

Labels
Dialect: Spanish Hacktoberfest-Accepted Language: Python 🌍 Opportunity: Translation
Projects
None yet
Milestone
Spanish Language Translation
Development

Successfully merging this pull request may close these issues.
2 participants
@gfant @madiedgar