src: fix finalization crash

PR-URL: nodejs#38250 Fixes: nodejs#38040 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
legendecas · Mar 29, 2022 · 2a8bdd1 · 2a8bdd1
1 parent b4090b9
commit 2a8bdd1
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/js_native_api_v8.cc b/src/js_native_api_v8.cc
@@ -379,6 +379,9 @@ class Reference : public RefBase {
 
  protected:
   inline void Finalize(bool is_env_teardown = false) override {
+    if (is_env_teardown) env_teardown_finalize_started_ = true;
+    if (!is_env_teardown && env_teardown_finalize_started_) return;
+
     // During env teardown, `~napi_env()` alone is responsible for finalizing.
     // Thus, we don't want any stray gc passes to trigger a second call to
     // `RefBase::Finalize()`. ClearWeak will ensure that even if the
@@ -467,6 +470,7 @@ class Reference : public RefBase {
     reference->Finalize();
   }
 
+  bool env_teardown_finalize_started_ = false;
   v8impl::Persistent<v8::Value> _persistent;
   SecondPassCallParameterRef* _secondPassParameter;
 };