-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic template for hpge post processing #2
base: main
Are you sure you want to change the base?
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Please also add a (possibly empty) |
Co-authored-by: Manuel Huber <[email protected]>
Co-authored-by: Manuel Huber <[email protected]>
do not worry that all CI fails, this is a known problem and currently affects all our packages that (transitively) depend on pint for units. see hgrecco/pint#1969 |
for me this PR looks quite fine. I did not really have a lot of time to use it, though. There is certainly quite some code (mostly the utility things) that could already be shared with the optical part. But I would propose to unify them after merging your and also my latest changes - just to avoid large diffs to manually merge. |
docs still need a lot of work and fixes but we can improve them in a future PR. you should rewrite the git history to remove the pre-commit bot commits before merging, I don't want to merge that junk. You just need to |
I think its worth taking time to cleanup and review things now. We could then review together in Munich.
…________________________________
From: Luigi Pertoldi ***@***.***>
Sent: Tuesday, November 19, 2024 11:47 PM
To: legend-exp/reboost ***@***.***>
Cc: Dixon, Toby ***@***.***>; Author ***@***.***>
Subject: Re: [legend-exp/reboost] basic template for hpge post processing (PR #2)
⚠ Caution: External sender
docs still need a lot of work and fixes but we can improve them in a future PR. you should rewrite the git history to remove the pre-commit bot commits before merging, I don't want to merge that junk. You just need to git rebase -i <hash of your first commit>, follow instructions to squash pre-commit bot commits into the previous, then force push
—
Reply to this email directly, view it on GitHub<#2 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANSET43WLXD5OQTJABMTBRL2BO5XLAVCNFSM6AAAAABQK3HXK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWHEYDKNZUGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Yes, let's keep this open and merge it together. |
…t intended to be outputed
Co-authored-by: Manuel Huber <[email protected]>
Draft PR that we can add to with the basic hpge post processing
legend-hpges-pygeom
evt tier can be added next / later.
Related: legend-exp/legend-pygeom-hpges#51