Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic template for hpge post processing #2

Open
wants to merge 91 commits into
base: main
Choose a base branch
from

Conversation

tdixon97
Copy link
Collaborator

@tdixon97 tdixon97 commented Oct 21, 2024

Draft PR that we can add to with the basic hpge post processing

  • utils for IO
  • basic windowing from evtid
  • windowing from times
  • basic detector response model (resolution)
  • more flexible detector response
  • dead layers (code is now in legend-hpges-pygeom
  • generalisation to allow easy user customization

evt tier can be added next / later.
Related: legend-exp/legend-pygeom-hpges#51

Copy link

codecov bot commented Oct 21, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ManuelHu
Copy link
Collaborator

Please also add a (possibly empty) __init__.py to the hpge directory. Otherwise the automatic API docs are not built... (I also just found that out in #3)

src/reboost/hpge/hit.py Outdated Show resolved Hide resolved
@tdixon97 tdixon97 marked this pull request as ready for review November 7, 2024 16:03
@ManuelHu
Copy link
Collaborator

ManuelHu commented Nov 7, 2024

do not worry that all CI fails, this is a known problem and currently affects all our packages that (transitively) depend on pint for units. see hgrecco/pint#1969

src/reboost/hpge/hit.py Outdated Show resolved Hide resolved
@ManuelHu
Copy link
Collaborator

for me this PR looks quite fine. I did not really have a lot of time to use it, though.

There is certainly quite some code (mostly the utility things) that could already be shared with the optical part. But I would propose to unify them after merging your and also my latest changes - just to avoid large diffs to manually merge.

@gipert
Copy link
Member

gipert commented Nov 19, 2024

docs still need a lot of work and fixes but we can improve them in a future PR. you should rewrite the git history to remove the pre-commit bot commits before merging, I don't want to merge that junk. You just need to git rebase -i <hash of your first commit>, follow instructions to squash pre-commit bot commits into the previous, then force push

@tdixon97
Copy link
Collaborator Author

tdixon97 commented Nov 19, 2024 via email

@gipert
Copy link
Member

gipert commented Nov 20, 2024

Yes, let's keep this open and merge it together.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants