Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting registry=None #61

Merged
merged 6 commits into from
Dec 5, 2024
Merged

fix setting registry=None #61

merged 6 commits into from
Dec 5, 2024

Conversation

ManuelHu
Copy link
Collaborator

@ManuelHu ManuelHu commented Dec 5, 2024 •
edited
Loading

the original approach did not work with all things in pyg4ometry, so we need to construct a temporary registry if we pass None.

@ManuelHu ManuelHu mentioned this pull request Dec 5, 2024
Closed
@ManuelHu ManuelHu changed the title add tests for registry=None fix setting registry=None Dec 5, 2024
@ManuelHu ManuelHu merged commit 8dff761 into main Dec 5, 2024
2 checks passed
@ManuelHu ManuelHu deleted the no-registry branch December 5, 2024 12:27
@ManuelHu ManuelHu linked an issue Dec 5, 2024 that may be closed by this pull request
allow construction without registry #59
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow construction without registry
1 participant
@ManuelHu