Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram: restrict more error messages to when they are necessary #106

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

ManuelHu
Copy link
Contributor

@gipert this should fix the points we discussed

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (c134065) to head (da6747d).
Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   76.69%   76.70%           
=======================================
  Files          46       46           
  Lines        3133     3134    +1     
=======================================
+ Hits         2403     2404    +1     
  Misses        730      730           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ManuelHu ManuelHu changed the title historam: restrict more error messages to when they are necessary histogram: restrict more error messages to when they are necessary Sep 19, 2024
src/lgdo/types/histogram.py Outdated Show resolved Hide resolved
@gipert gipert added bug Something isn't working types LGDO types labels Sep 20, 2024
@gipert gipert merged commit fc6450f into legend-exp:main Sep 21, 2024
15 checks passed
@ManuelHu ManuelHu deleted the histogram-fixes branch November 26, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types LGDO types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants