[MIG][14.0] Base #4
Conversation
| "merged_modules": { | ||
| "partner_bank_active": "base" | ||
| }, | ||
| "__comment__": "The members below are only used to help the analysis process", |
There was a problem hiding this comment.
Yikes! those __comment__... 🙈
Just use other format. 🤷♂️ See legalsylvain/server-tools#4 (review).
| @@ -0,0 +1,123 @@ | |||
| ---Models in module 'base'--- | |||
There was a problem hiding this comment.
Now that we're in the works of refactoring and all that stuff, I have to tell you something: I hate the syntax of these files.
Couldn't we just have a YAML, which supports proper comments and syntax highlighting, and besides allows automated parsing to check migration completion status? Or even a CSV... but not this please 🙈
(Note: of course just a personal preference and absolutely not important. But really, this is awful 😆)
There was a problem hiding this comment.
Hi @yajo. Well it's a distinct point. You're probably right. But it requires a big extra work. Feel free to make a PR against upgrade_analysis module, that is responsible of the generation of the files.
|
Thanks ! |
|
cherry picked here. #5 |
No description provided.