[RFR] OpenUpgrade framework patches #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
StefanRijnhart
force-pushed
the
rfr/14.0/openupgrade_framework
branch
from
e408226 to
151fbf4
Compare
StefanRijnhart
force-pushed
the
rfr/14.0/openupgrade_framework
branch
from
151fbf4 to
447b0e7
Compare
yajo
suggested changes
Dec 7, 2020
Comment on lines
+9
to
+55
| def _drop_table(self): | ||
| """ Never drop tables """ | ||
| for model in self: | ||
| if self.env.get(model.model) is not None: | ||
| openupgrade.message( | ||
| self.env.cr, "Unknown", False, False, | ||
| "Not dropping the table or view of model %s", model.model) | ||
|
|
||
|
|
||
| def _drop_column(self): | ||
| """ Never drop columns """ | ||
| for field in self: | ||
| if field.name in models.MAGIC_COLUMNS: | ||
| continue | ||
| openupgrade.message( | ||
| self.env.cr, "Unknown", False, False, | ||
| "Not dropping the column of field %s of model %s", field.name, | ||
| field.model, | ||
| ) | ||
| continue | ||
|
|
||
|
|
||
| IrModel._drop_column = _drop_column | ||
| IrModel._drop_table = _drop_table | ||
|
|
||
|
|
||
| @api.model | ||
| def _process_end(self, modules): | ||
| """ Don't warn about upgrade conventions from Odoo | ||
| ('fields should be explicitely removed by an upgrade script') | ||
| """ | ||
| with mute_logger('odoo.addons.base.models.ir_model'): | ||
| return IrModelData._process_end._original_method(self, modules) | ||
|
|
||
|
|
||
| _process_end._original_method = IrModelData._process_end | ||
| IrModelData._process_end = _process_end | ||
|
|
||
|
|
||
| def _module_data_uninstall(self): | ||
| """ Don't delete many2many relation tables. Only unlink the | ||
| ir.model.relation record itself. | ||
| """ | ||
| self.unlink() | ||
|
|
||
|
|
||
| IrModelRelation._module_data_uninstall = _module_data_uninstall |
Comment on lines
+38
to
+41
| _check_xml._original_method = View._check_xml | ||
| View._check_xml = _check_xml | ||
| handle_view_error._original_method = View.handle_view_error | ||
| View.handle_view_error = handle_view_error |
Comment on lines
+20
to
+28
| savepoint = str(uuid4) | ||
| try: | ||
| self.env.cr.execute('SAVEPOINT "%s"' % savepoint) | ||
| return BaseModel.unlink._original_method(self) | ||
| except Exception as e: | ||
| self.env.cr.execute('ROLLBACK TO SAVEPOINT "%s"' % savepoint) | ||
| _logger.warning( | ||
| "Could not delete obsolete record with ids %s of model %s: %s", | ||
| self.ids, self._name, e) |
There was a problem hiding this comment.
You could just use with self.env.cr.savepoint(): ...
Comment on lines
+32
to
+33
| unlink._original_method = BaseModel.unlink | ||
| BaseModel.unlink = unlink |
| if ( | ||
| "base" in self | ||
| and self["base"].dbdemo | ||
| and self["base"].installed_version < odoo.release.major_version |
There was a problem hiding this comment.
🚫 Beware! You have to use a smart version comparison algorithm. Check out odoo.tools.parse_version.
Comment on lines
+20
to
+21
| update_from_db._original_method = Graph.update_from_db | ||
| Graph.update_from_db = update_from_db |
|
I'm fast merging all the PR, because it make more complex the developpement to have multiple PR, even if @yajo could be valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.