Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Standalone openupgrade_records #1

Conversation

StefanRijnhart
Copy link

@StefanRijnhart StefanRijnhart commented Nov 29, 2020

Separates the patches of the openupgrade_records module from the migration patches, so that openupgrade_records can in some form be adopted in a general OCA repo.

I've basically implemented what I described in OCA/OpenUpgrade#2440 (comment)

@StefanRijnhart
Copy link
Author

StefanRijnhart commented Nov 30, 2020

Even if openupgrade_records is now proposed into server-tools as upgrade_analysis, we might want to take from this the cleaned up patches in openupgrade_framework.

@legalsylvain
Copy link
Owner

merging this PR for the refactoring of openupgrade_framework.

@legalsylvain legalsylvain merged commit 6f9aba5 into legalsylvain:14.0-upgrade-pocalypse Dec 1, 2020
@StefanRijnhart
Copy link
Author

Thanks. Shall I propose follow-up PRs to delete openupgrade_records and add a full analysis? We can then continue with the migration framework itself.

@legalsylvain
Copy link
Owner

legalsylvain commented Dec 1, 2020

Shall I propose follow-up PRs to delete openupgrade_records and add a full analysis?

If you have time, of course !

We can then continue with the migration framework itself.

I wrote a question regarding aa pending issue. It concerns both projects : OCA/server-tools#1941 (comment)

legalsylvain added a commit that referenced this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants