Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Preserve first-position of some essential mill options #42

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Conversation

lefou
Copy link
Owner

@lefou lefou commented Nov 14, 2022

@lefou lefou changed the title Preseve first-position of some essential mill opitons Preserve first-position of some essential mill opitons Nov 14, 2022
@lefou lefou changed the title Preserve first-position of some essential mill opitons Preserve first-position of some essential mill options Nov 14, 2022
@ckipp01
Copy link

ckipp01 commented Nov 15, 2022

Just dropping by saying I did test with the new millw in this pr and it does seem to fix the issue with Metals 👍🏼 .

@lefou lefou marked this pull request as ready for review November 15, 2022 14:05
@lefou lefou merged commit 5dc54a9 into main Nov 15, 2022
@lefou lefou deleted the fix-args branch November 15, 2022 14:06
@lefou lefou added this to the after 0.4.4 milestone Nov 15, 2022
lefou added a commit to com-lihaoyi/mill that referenced this pull request Nov 15, 2022
Also respect an already set DEFAULT_MILL_VERSION variable.

Adapted from lefou/millw#42

Fix #2123

Pull request: #2124
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants