New format option untaggedSuffix
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
reviewed
Sep 1, 2022
lefou
changed the title
appendSnapshotuntaggedSuffix
lefou
force-pushed
the
append-snapshot
branch
from
d4fa410 to
eac2790
Compare
ckipp01
reviewed
Sep 1, 2022
| @@ -52,6 +58,28 @@ case class VcsState( | |||
| case t => t | |||
| } | |||
|
|
|||
| @deprecated("Binary compatibility shim. Use other overload instead.", "mill-vcs-verison after 0.2.0") | |||
| private[version] def format( | |||
There was a problem hiding this comment.
Maybe a naive question, but is this needed? With the new change it won't break compat for existing users right because it has a default value?
There was a problem hiding this comment.
Typically, you're right, as most Mill plugins are used in build scripts, hence their use site is always recompiled, when the version changes.
But with your new mill-ci-release plugin, we started to have downstream users who depend on binary published artifacts. And there is a high change of really breaking the build, when the user is also explicitly importing both plugins.
There was a problem hiding this comment.
Ahhh, so you're saying it's my fault! 😆
Kidding, makes sense.
ckipp01
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing artifacts to Maven Snapshot repositories, the version needs to end in
-SNAPSHOT.With this addition, we can automatically add such a suffix, while keeping a unique version based on the last tag.