Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence stderr from os.proc calls #111

Merged
merged 2 commits into from
May 21, 2023
Merged

Silence stderr from os.proc calls #111

merged 2 commits into from
May 21, 2023

Conversation

lihaoyi
Copy link
Collaborator

@lihaoyi lihaoyi commented May 20, 2023

These print out fatal: no tag exactly matches messages. In the past it printed once, now it prints continuously due to T.inputs properly polling for changes, which is super annoying

@lihaoyi lihaoyi requested a review from lefou May 20, 2023 21:00
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #111 (4afc78e) into main (e80da75) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files           3        3           
  Lines          41       41           
  Branches        6        6           
=======================================
  Hits           40       40           
  Misses          1        1           
Impacted Files Coverage Δ
.../de/tobiasroeser/mill/vcs/version/VcsVersion.scala 100.00% <100.00%> (ø)

Copy link
Owner

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you!

@lefou lefou merged commit 33d3b50 into main May 21, 2023
@lefou lefou deleted the lihaoyi-patch-1 branch May 21, 2023 20:45
@lefou lefou added this to the after 0.3.1 milestone May 21, 2023
@lefou
Copy link
Owner

lefou commented May 21, 2023

Available in 0.3.1-7-33d3b5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants