compute convolution channels together #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, in the original code, when concatenating the uncomputed
pctogether and then computing, we would end up with a completely wrong array, and this array was different than the one that would be produced when we compute thepcand then concatenate.I was unsure how to fix this problem (it had something to do with the order of operations and the memory mapping of tasks in the Dask delayed task graph), so I decided to write something where we didn't even need to do any concatenation on the
pcarrays, and instead do the entire convolution in one go, i.e. one call ofxr.apply_ufunc, instead of one call per channel.