Merge pull request #283 from leepeuker/280-rating-is-editable-when-no…

…t-having-clicked-on-the-edit-button-in-the-movie-page Fix UX issues with rating stars on movie detail page
leepeuker · Feb 15, 2023 · 14e8332 · 14e8332
2 parents f441fc3 + 98266cf
commit 14e8332
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/public/js/app.js b/public/js/app.js
@@ -7,6 +7,8 @@ if ('serviceWorker' in navigator) {
     })
 }
 
+let ratingEditMode = false
+
 async function searchTmdbWithLogModalSearchInput() {
     resetLogModalSearchResults()
     document.getElementById('logPlayModalSearchSpinner').classList.remove('d-none')
@@ -137,6 +139,7 @@ function updateLogPlayModalButtonState() {
 }
 
 document.getElementById('logPlayModalSearchInput').addEventListener('keypress', loadLogModalSearchResultsOnEnterPress);
+
 function loadLogModalSearchResultsOnEnterPress(event) {
     // 13=enter, works better to check the key code because the key is named differently on mobile
     if (event.keyCode === 13) {
@@ -307,6 +310,10 @@ async function fetchRating(tmdbId) {
 }
 
 function setRatingStars(context, newRating) {
+    if (context === 'movie' && ratingEditMode === false) {
+        return
+    }
+
     if (getRatingFromStars(context) == newRating) {
         newRating = 0
     }

diff --git a/public/js/movie.js b/public/js/movie.js
@@ -1,4 +1,3 @@
-let ratingEditMode = false
 let originalRating
 
 function deleteWatchDate() {
@@ -75,7 +74,7 @@ function saveRating() {
 function resetRating(e) {
     ratingEditMode = true
 
-    setRatingStars('logPlayModal', 0)
+    setRatingStars('movie', 0)
     saveRating(e)
 
     ratingEditMode = false