You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i never quite liked the naming of result.sels or that it gets accumulated regardless of whether the user asked for it or not. it also doesnt feel right that whitelist accumulation uses this return style but whitelist testing uses the shouldDrop() callback style. didRetain() which fires for every undropped selector feels more consistent.
this would be a breaking change but to a non-primary API, so i dont think a 2.0 is warranted; hopefully no-one's life depends on dropcss 😱
The text was updated successfully, but these errors were encountered:
I noticed this change while refactoring some code. Dropping sels would for us cause things to break stuff. This API is also documented in the README's example code.
I'd recommend you either bump the version to 2.0, or add the new API in parallel with the old.
i never quite liked the naming of
result.sels
or that it gets accumulated regardless of whether the user asked for it or not. it also doesnt feel right that whitelist accumulation uses this return style but whitelist testing uses the shouldDrop() callback style. didRetain() which fires for every undropped selector feels more consistent.this would be a breaking change but to a non-primary API, so i dont think a 2.0 is warranted; hopefully no-one's life depends on dropcss 😱
The text was updated successfully, but these errors were encountered: