Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced angular.(to|From)Json with Utilities. #63

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Replaced angular.(to|From)Json with Utilities. #63

merged 2 commits into from
Dec 22, 2020

Conversation

Matthew-Wise
Copy link
Contributor

@Matthew-Wise Matthew-Wise commented Dec 22, 2020 •
edited by leekelleher
Loading

Description

Removing the use of angular.ToJson and FromJson. This is a breaking change as it requires version 8.7+ of Umbraco.

Tested on v8.9.1

Related Issues?

#38

Types of changes

  • Documentation change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the coding style of this project.
  • My changes generate no new warnings.
  • My change requires a change to the documentation.
  • I have updated the corresponding documentation.
  • I have read the CONTRIBUTING and CODE_OF_CONDUCT documents.

leekelleher
leekelleher approved these changes Dec 22, 2020
View reviewed changes
Copy link
Owner

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @Matthew-Wise!

@leekelleher
Whitespace housekeeping
3d50d23 
My OCD kicked in! 👼😈
@leekelleher leekelleher linked an issue Dec 22, 2020 that may be closed by this pull request
Decoupling from AngularJS #38
Closed
@leekelleher leekelleher merged commit 1507dd2 into leekelleher:dev/v2.0 Dec 22, 2020
@leekelleher leekelleher mentioned this pull request Dec 22, 2020
Closed
@leekelleher leekelleher added this to the 2.0.0 milestone Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekelleher leekelleher leekelleher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Decoupling from AngularJS
2 participants
@Matthew-Wise @leekelleher