FloatOption: Add support for scientific notation and + sign #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flavono123
commented
Jan 15, 2020
•
flavono123
commented
- parse the float with a prepended + sign
- parse scientific notations
- remove the todo comment
Signed-off-by: Hansuk <[email protected]>
- reference: https://stackoverflow.com/questions/638565/parsing-scientific-notation-sensibly - remove the todo comment(no idea for etc) Signed-off-by: Hansuk <[email protected]>
olleolleolle
changed the title
olleolleolle
approved these changes
Jan 16, 2020
leejarvis
requested changes
Jan 16, 2020
There was a problem hiding this comment.
This is great, thanks @flavono123! I've added one comment but otherwise it's good to merge
leejarvis
reviewed
Jan 16, 2020
- #250 (comment) - #250 (comment) Signed-off-by: Hansuk <[email protected]>
|
Thank you too for reviews on my commits and I admit your comments @leejarvis |
leejarvis
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Great work, thank you! 💙
Btw, for the style, how about add a lint(rubocop) and run in a travis build?
I do like the idea of adding a linter, through I'm not a fan of the Rubocop defaults so I'd likely need to spend a bit of time playing with it. Let's consider that in a separate PR.
Thanks again! I'll get a new version of Slop cut and release this
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 23, 2020
Update ruby-slop to 4.8.0. v4.8.0 (2020-01-17) ------------------- Features: * Add support for prefixing integer values with `+` character [#243](leejarvis/slop#243) (Juha Ylitalo) * Add support for parsing floats with scientific notation [#250](leejarvis/slop#250) (Hansuk Hong) Maintenance: * Add 2.7.0 to CI and fix warnings [#248](leejarvis/slop#248) (Juha Ylitalo, Andrew Kane)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.