Field labels and BDD tests for Bank Account screen #8677
+111
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously just three unlabelled text boxes. This adds labels and renders them correctly aligned in the two-column grid.
`entity_bank_account.bic` is a required field in the underlying database. Make this a required field on the UI to allow client-side validation.
Commit c90ddfa introduced self-closing `<lsmb-text />` tags, which our HTML linter complains about. Fixed with `<lsmb-text>...</lsmb-text>` tags.
This patch makes PageObject::App::Roles::Dynatable look only at visible tables on the page, allowing it to have wider utility. It can now be used with pages that have multiple tabs, where only one tab is visible at a time, but each has a table element. Now raises a warning if no visible tables are found, or if multiple tables are visible, which can otherwise cause non-obvious failures when writing tests.
Basic BDD tests for adding a bank account to a company.
Commit 601cc58 changed PageObject::App::Roles::Dynatable to look only at visible dynatable elements on the page, using an `is_displayed` test, but this failed for testing with Firefox. This patch is a simplification using just xpath to find the first visible dynatable element, which works for both Chrome and Firefox browser tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds field labels to the inputs of the Bank Account page and
adds basic BDD tests for adding a bank account to an entity.