Fix copying framework when building a new version #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylefleming
force-pushed
the
fix/rebuilding-frameworks
branch
2 times, most recently
from
153e2f6 to
0ebf099
Compare
Fixes an issue where copying the generated framework after a build would fail if the framework already exists in the GeneratedFrameworks folder, even if that existing framework is out-of-date.
kylefleming
force-pushed
the
fix/rebuilding-frameworks
branch
from
0ebf099 to
ae24842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where copying the generated framework after a build would fail if the framework already exists in the GeneratedFrameworks folder, even if that existing framework is out-of-date.
This issue is caused by
FileUtils.mvexibiting different behavior for files than for directories. If the destination already exists and is a file then:force => truecausesFileUtils.mvto remove the destination and proceed with the move as expected. However, if the destination already exists and is a directory, thenFileUtils.mvraises an error and by specifying the:force => trueflag, that error is swallowed. This effectively results in a silent failure of theFileUtils.mvcommand if the destination already exists and is a directory (yet works as expected if it's a file).Note: This PR is built on top of #103. I'll rebase this PR when that gets merged (or another fix for travis builds is committed).