Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Update for Moodle39 #5

Merged
merged 8 commits into from
Jun 20, 2020

Conversation

justusdieckmann
Copy link
Contributor

Fixed behattests, enforced moodle codestyle and removed duplicated code, so that travis now succeeds.
A new release is not needed.

@mwuttke
Copy link

mwuttke commented Jun 16, 2020

@justusdieckmann 👍 Looks good.

Just one question:
Why did you choose xenial as the default distro in the travis.ci test?

Thanks for the good job & Greetings,
Michael

@justusdieckmann
Copy link
Contributor Author

justusdieckmann commented Jun 19, 2020

(Edited, because I think I first misunderstood your question)

In most of our other travis configs, we specified trusty as the distro. That didn't work anymore because of a problem with PHP 7.4 and php-gd and php-zip, so I updated all the configs to dist:xenial, which is also the default, if you don't specify a distro at all. But I thought it would be nice to specify xenial anyway, so that there wouldn't be random failures if travis decided to update the default and there were any compatibility problems with the next distro.

Thanks for the quick response,
Justus

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c71b2a7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   59.50%           
  Complexity        ?      144           
=========================================
  Files             ?       11           
  Lines             ?      568           
  Branches          ?        0           
=========================================
  Hits              ?      338           
  Misses            ?      230           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71b2a7...875a861. Read the comment docs.

@mwuttke mwuttke merged commit ece117f into learnweb:master Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants