Skip to content

Commit

Permalink
Use podman for builds rather than redhat action
Browse files Browse the repository at this point in the history
Having issues with podman recognizing multi-arch builds from buildah
  • Loading branch information
learnitall committed Jul 19, 2021
1 parent 11c6d91 commit a9fb48c
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions .github/workflows/functional.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,24 +88,20 @@ jobs:
echo IMAGE_TAG=${{ matrix.tag_prefix }}${{ github.sha }} >> $GITHUB_ENV
- name: Build ${{ matrix.containerfile }}
id: build-image
uses: redhat-actions/buildah-build@v2
with:
arch: ${{ matrix.arch }}
image: ${{ matrix.image_name }}
tags: ${{ env.IMAGE_TAG }}
dockerfiles: ${{ matrix.containerfile }}
build-args: ARCH=${{ matrix.arch }}
run: >-
podman build . -t ${{ matrix.image_name }}:${{ env.IMAGE_TAG }}
-f ${{ matrix.containerfile }} --arch ${{ matrix.arch }}
- name: Export image to archive
run: >-
podman save --output ${{ matrix.image_name }}.${{ env.IMAGE_TAG }}.tar
${{ steps.build-image.outputs.image }}:${{ env.IMAGE_TAG }}
localhost/${{ matrix.image_name }}:${{ env.IMAGE_TAG }}
- name: Save Image as Artifact
uses: actions/upload-artifact@v2
with:
name: ${{ matrix.image_name }}.${{ env.IMAGE_TAG }}
path: ${{ matrix.image_name }}.${{ env.IMAGE_TAG }}.tar
retention-days: 10
- name: Set benchmark image environment variable
run: echo ${{ matrix.env_var }}=${{ steps.build-image.outputs.image }}:${{ env.IMAGE_TAG }} >> $GITHUB_ENV
run: echo ${{ matrix.env_var }}=localhost/${{ matrix.image_name }}:${{ env.IMAGE_TAG }} >> $GITHUB_ENV
- name: Run functional tests
run: tox -e functional -- -m ${{ matrix.benchmark }}

1 comment on commit a9fb48c

@learnitall
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually is an issue with podman save recognizing multi-arch images: containers/podman#10835. Will need to modify runners to use a newer version of podman that includes the fix.

Please sign in to comment.