Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pickles seasoned for 0.14 #7358

Merged

Conversation

radinamatic
Copy link
Member

Summary

Reviewer guidance

References


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Sorry, something went wrong.

@radinamatic radinamatic added the TODO: needs review Waiting for review label Jul 22, 2020
@radinamatic radinamatic added this to the 0.14.0 milestone Jul 22, 2020
@radinamatic radinamatic added P0 - critical Priority: Release blocker or regression and removed P0 - critical Priority: Release blocker or regression labels Jul 22, 2020
@jonboiser jonboiser merged commit d263139 into learningequality:release-v0.14.x Jul 22, 2020
@radinamatic
Copy link
Member Author

Thank you! 👍

@radinamatic radinamatic deleted the more-0.14-gherkins branch July 22, 2020 23:20
@jonboiser jonboiser removed the TODO: needs review Waiting for review label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated tests and gherkin stories still needed for #6865
2 participants