-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable "Edit on Github" because it got fixed #2999
Re-enable "Edit on Github" because it got fixed #2999
Conversation
Codecov Report
@@ Coverage Diff @@
## release-v0.7.x #2999 +/- ##
==================================================
- Coverage 76.27% 76.11% -0.16%
==================================================
Files 187 187
Lines 7624 7269 -355
Branches 983 916 -67
==================================================
- Hits 5815 5533 -282
+ Misses 1624 1557 -67
+ Partials 185 179 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
have we been able to confirm that the link actually works? |
(I'm not sure how to test this without merging in) |
@indirectlylit yes it works, see upstream |
very nice |
Summary
Disabled in #2850
Fixed upstream in readthedocs/readthedocs.org#3203
Has to be sync'ed to develop after.
Reviewer guidance
IMO we should re-introduce it on User Docs, too, until a feedback button is created to replace it.
References
n/a
Contributor Checklist
Reviewer Checklist
yarn
andpip
)