Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mostly useless warning against using npm #11697

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 4, 2024

Summary

  • A long, long time ago, in a galaxy far, far away, we added a preinstall script to prevent people using npm to install dependencies.
  • Due to a bug in NPM from v7 onwards that devs show no inclination to fix [BUG] Preinstall script runs after installing dependencies npm/cli#2660 this now only runs after all dependencies have been installed. It's possible that this could still be useful, but after we saw a false positive for the check, where someone running yarn was prevented from installing dependencies, it seems better to just remove it as it is mostly useless.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jan 4, 2024
@rtibbles rtibbles requested a review from marcellamaki January 4, 2024 17:03
@github-actions github-actions bot added DEV: tools Internal tooling for development SIZE: very small labels Jan 4, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me! merging into 0.16.x so it can be updated before new kolibri-tools version is released

@rtibbles rtibbles merged commit 3a50de0 into learningequality:release-v0.16.x Jan 4, 2024
34 checks passed
@rtibbles rtibbles deleted the yarn_check branch January 4, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: tools Internal tooling for development SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Preinstall script runs after installing dependencies
2 participants