Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APK building to PR asset building and release pipelines #11116

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 16, 2023

Summary

  • Adds building of a release asset for all Kolibri releases which will get released to the internal testing track on the play store
  • Adds promoting of internal testing track asset to open testing track for final releases
  • Adds building and uploading of non-release APK files to PR assets

References

Integrates learningequality/kolibri-installer-android#152 into Kolibri

Reviewer guidance

The only real way to test the release part of this is to merge it, but please double check my yml.

PR build showing an APK should be a sign of success for the other part!


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added the DEV: dev-ops Continuous integration & deployment label Aug 16, 2023
@rtibbles rtibbles added the TODO: needs review Waiting for review label Aug 16, 2023
@rtibbles rtibbles force-pushed the i_for_one_welcome_our_android_overlords branch 2 times, most recently from 04bb4d9 to 8cb2eff Compare August 17, 2023 00:36
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to object on this PR changes, but it seems the build_apk workflow has a problem with a required dependency on setuptools

@rtibbles
Copy link
Member Author

Yeah, I am making some tweaks on the other repo to fix up these issues.

@rtibbles rtibbles force-pushed the i_for_one_welcome_our_android_overlords branch from 8cb2eff to aa91831 Compare August 17, 2023 19:54
@rtibbles
Copy link
Member Author

This is now only failing because of permissions issues for the secrets I am referencing. I am pretty confident that this is good to merge.

@rtibbles
Copy link
Member Author

Merging, on my own head be it if anything breaks.

@rtibbles rtibbles merged commit f1f79f5 into learningequality:release-v0.16.x Aug 17, 2023
@rtibbles rtibbles deleted the i_for_one_welcome_our_android_overlords branch August 17, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants