-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Kolibri server start to a separate persistent foreground service #52
Conversation
create_premigrated_db: | ||
pip install whl/*.whl | ||
KOLIBRI_HOME=tmphome kolibri manage migrate | ||
cp tmphome/db.sqlite3 src/db.sqlite3.empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wait... it escalated from there! Additional PR incoming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just flagging that I'm thinking of moving some of the Android code for creating the foreground service into pyeverywhere, and hopefully formalizing the concept of a service in the library. I think it's best to just focus on getting everything working first though, and then we can look at how best to design the longer-term approach. :)
This relies on the following changes to both pyeverywhere and kolibri:
(May be easiest to review main.py by just viewing the new version, rather than the diff)