Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check env var to determine the apk path #40

Closed
wants to merge 1 commit into from

Conversation

lyw07
Copy link

@lyw07 lyw07 commented Dec 20, 2019

This PR is to fix our current android build failure. The issue is that apk file got copied to /home/kivy instead of /home/kivy/dist, and I assume this is when P4A_RELEASE_KEYSTORE is set to /home/kivy/ instead of /home/kivy/dev.keystore

@lyw07 lyw07 requested review from kollivier and DXCanas December 20, 2019 00:59
@DXCanas
Copy link
Member

DXCanas commented Dec 20, 2019

I haven't gotten a chance to test locally yet, but my first questions is why it took so long for this to manifest? Has p4a changed the output directory from dist @kollivier

@indirectlylit
Copy link

ref: learningequality/kolibri#6420

@kollivier
Copy link
Contributor

The reason is that Docker has been using cached everything for a very long time, and so when the cache was cleared the other day, it finally went about updating all the dependencies. From what I can tell, it applied some updates that are over several months old. So it could be a p4a update, or some other reason. It definitely is a change from previous behavior, so I want to get to the bottom of what exactly happened to figure out if we need to be pinning a dependency, etc.

There were also definitely a couple pyeverywhere bugs I introduced while refactoring. Because I can't test locally on Mac with p4a anymore due to dependency build errors, I was relying on the Android build to error out if I made a mistake. Apologies for that. I need to just bite the bullet and set up CI for pyeverywhere that builds a sample project to ensure the change is kosher!

@DXCanas
Copy link
Member

DXCanas commented Dec 21, 2019

Turns out it was a p4a change, and I've resolved it in #43

Thanks for all the work here @lyw07, you definitely nailed the symptom

@DXCanas DXCanas closed this Dec 21, 2019
@lyw07
Copy link
Author

lyw07 commented Dec 21, 2019

🎉🎉🎉

@indirectlylit
Copy link

what's p4a?

@indirectlylit
Copy link

oh - python for android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants