Update strings in Android App #186

rtibbles · 2024-01-10T01:09:39Z

Removes unneeded resource strings
Fixes residual private version code from p4a that would have prevented the app from upgrading
Finds translated user text for every user facing text apart from the Persistent Foreground notification channel, for which I could not find an appropriate string in Kolibri
Updates the create_string script to search through Kolibri message files and po files to find translations for messages
Updates the generated username to "Learner" translated
Caches the above generated username to avoid weird behaviour if the user switches their Android device language

Fixes #172
Fixes #185

Update strings where possible to ones available in Kolibri.

…available.

…r label.

bjester

LGTM

python-for-android/dists/kolibri/src/main/java/org/learningequality/Kolibri/App.java

python-for-android/dists/kolibri/src/main/java/org/learningequality/NotificationRef.java

scripts/create_strings.py

python-for-android/dists/kolibri/src/main/java/org/kivy/android/PythonUtil.java

rtibbles added 5 commits January 9, 2024 16:22

Remove unneeded resource strings.

bc3f45d

Update strings where possible to ones available in Kolibri.

Update string borrowing code to get all strings for strings.xml when …

8d9dec0

…available.

Mark task_worker_process string as untranslatable.

3e34e46

Remove private version string in favour of version code.

f536093

Remove autogenerated proquint username in favour of translated Learne…

45bf636

…r label.

rtibbles requested review from bjester and jredrejo January 10, 2024 01:09

bjester approved these changes Jan 10, 2024

View reviewed changes

rtibbles added 2 commits January 10, 2024 14:47

Use static variable for PrivateVersion.

ff1cbb3

Don't conflict file variable name with outer context scope.

be42b5c

rtibbles merged commit 3340ce1 into develop Jan 10, 2024
4 checks passed

rtibbles deleted the cheeky_strings branch January 10, 2024 22:55

Provide feedback