Work manager integration #119
Conversation
rtibbles
force-pushed
the
work_manager_integration
branch
from
19cbe3c to
119c20a
Compare
rtibbles
force-pushed
the
work_manager_integration
branch
from
119c20a to
8d00eca
Compare
Use Java to launch tasks for avoid introspection issues.
Add notification icon.
rtibbles
force-pushed
the
work_manager_integration
branch
from
135c2a3 to
f2db879
Compare
Remove notifications when non-long running tasks finish.
Remove need to refer to mWorker process variable that can get mixed up.
Makefile
Outdated
| @@ -44,7 +44,7 @@ needs-android-dirs: | |||
|
|
|||
| # Clear out apks | |||
| clean: | |||
| - rm -rf dist/*.apk src/kolibri tmpenv | |||
| - rm -rf dist/*.apk src/kolibri tmpenv src/*.pyc | |||
There was a problem hiding this comment.
-rf is recursive when you delete a folder itself, but I don't think this will recursively delete from subfolders with the wildcards like that, so it may be good to adapt to be safer.
Confirmed:
| @@ -72,9 +72,25 @@ src/kolibri: clean | |||
| # patch Django to allow migrations to be pyc files, as p4a compiles and deletes the originals | |||
| sed -i 's/if name.endswith(".py"):/if name.endswith(".py") or name.endswith(".pyc"):/g' src/kolibri/dist/django/db/migrations/loader.py | |||
|
|
|||
| .PHONY: check-android-clean | |||
| check-android-clean: | |||
| @git diff --quiet --exit-code python-for-android || (echo "python-for-android directory has uncommitted changes in the working tree" && exit 1) | |||
There was a problem hiding this comment.
Is this just displayed as a warning? Or does the exit 1 make it bail, I guess? Would one not want to be able to build while the P4A is still being iterated.
Probably I'm also misinterpreting these new make targets. Could you add a one-line comment on each as to what it does?
There was a problem hiding this comment.
We can build while the Java files are being actively edited - we just can't reimport from the bootstrap while that is the case. Will add some comments to make it clearer.
| @@ -33,14 +33,25 @@ Follow the instructions from the command to set the additional environment varia | |||
|
|
|||
There was a problem hiding this comment.
Worth above these pieces suggesting a venv?
|
Comments from review have been addressed. A follow up issue for the remaining fix for task running is here: #132 |
Fixes #103
Fixes #104
Fixes #105
Depends on learningequality/kolibri#9503 to expose the hooks and updates to the task machinery
Opening this as a WIP, as I have not actually tested any of this code as yet.