Limit progress integers to less than or equal to 10000

learningequality · Mar 19, 2024 · 6ec6b41 · 6ec6b41
1 parent cb9c66d
commit 6ec6b41
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/android_app_plugin/kolibri_plugin.py b/src/android_app_plugin/kolibri_plugin.py
@@ -9,6 +9,7 @@
 
 Locale = autoclass("java.util.Locale")
 Task = autoclass("org.learningequality.Task")
+PROGRESS_LIMIT = 10000
 
 
 logger = logging.getLogger(__name__)
@@ -68,6 +69,13 @@ def update(self, job, orm_job, state=None, **kwargs):
             else:
                 progress = -1
                 total_progress = -1
+
+            # avoid passing integers that are too large
+            # PROGRESS_LIMIT gives sufficient precision for a % progress calculation
+            if total_progress > PROGRESS_LIMIT:
+                progress = progress // total_progress * PROGRESS_LIMIT
+                total_progress = PROGRESS_LIMIT
+
             Task.updateProgress(
                 orm_job.worker_extra,
                 status.title,